Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused noUiSlider pips #2296

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore: remove unused noUiSlider pips #2296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/uhk-web/src/app/components/device/led-settings/led-settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ <h3 class="pt-3">LED brightness</h3>
[min]="0"
[max]="255"
[step]="1"
[pips]="sliderPips"
[(ngModel)]="iconsAndLayerTextsBrightness"
(ngModelChange)="onSetPropertyValue('iconsAndLayerTextsBrightness', $event)"></slider-wrapper>
</div>
Expand All @@ -23,7 +22,6 @@ <h3 class="pt-3">LED brightness</h3>
[min]="0"
[max]="255"
[step]="1"
[pips]="sliderPips"
[(ngModel)]="alphanumericSegmentsBrightness"
(ngModelChange)="onSetPropertyValue('alphanumericSegmentsBrightness', $event)"></slider-wrapper>
</div>
Expand All @@ -34,7 +32,6 @@ <h3 class="pt-3">LED brightness</h3>
[min]="0"
[max]="255"
[step]="1"
[pips]="sliderPips"
[(ngModel)]="keyBacklightBrightness"
(ngModelChange)="onSetPropertyValue('keyBacklightBrightness', $event)"></slider-wrapper>
</div>
Expand Down
7 changes: 0 additions & 7 deletions packages/uhk-web/src/app/components/device/led-settings/led-settings.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
SetUserConfigurationRgbValueAction,
SetUserConfigurationValueAction
} from '../../../store/actions/user-config';
import { SliderPips } from '../../slider-wrapper/slider-wrapper.component';
import { Observable, Subscription } from 'rxjs';
import { faSlidersH } from '@fortawesome/free-solid-svg-icons';
import { BacklightingMode, RgbColorInterface, UserConfiguration } from 'uhk-common';
Expand Down Expand Up @@ -36,12 +35,6 @@ export class LEDSettingsComponent implements OnInit, OnDestroy {
public iconsAndLayerTextsBrightness: number = 0;
public alphanumericSegmentsBrightness: number = 0;
public keyBacklightBrightness: number = 0;
public sliderPips: SliderPips = {
mode: 'positions',
values: [0, 50, 100],
density: 6,
stepped: true
};
faSlidersH = faSlidersH;

private userConfig$: Observable<UserConfiguration>;
Expand Down
12 changes: 0 additions & 12 deletions packages/uhk-web/src/app/components/device/mouse-speed/mouse-speed.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ <h3>Mouse pointer speed</h3>
[min]="moveSettings.min"
[max]="moveSettings.max"
[step]="moveSettings.step"
[pips]="sliderPips"
valueUnit="px/s"
[(ngModel)]="mouseMoveInitialSpeed"
(ngModelChange)="onSetMouseMovePropertyValue('mouseMoveInitialSpeed', $event)"/>
Expand All @@ -41,7 +40,6 @@ <h3>Mouse pointer speed</h3>
[min]="moveSettings.min"
[max]="moveSettings.max"
[step]="moveSettings.step"
[pips]="sliderPips"
valueUnit="px/s"
[(ngModel)]="mouseMoveBaseSpeed"
(ngModelChange)="onSetMouseMovePropertyValue('mouseMoveBaseSpeed', $event)"/>
Expand All @@ -52,7 +50,6 @@ <h3>Mouse pointer speed</h3>
[min]="moveSettings.min"
[max]="moveSettings.max"
[step]="moveSettings.step"
[pips]="sliderPips"
valueUnit="px/s"
[(ngModel)]="mouseMoveAcceleration"
(ngModelChange)="onSetMouseMovePropertyValue('mouseMoveAcceleration', $event)"/>
Expand All @@ -63,7 +60,6 @@ <h3>Mouse pointer speed</h3>
[min]="moveSettings.min"
[max]="moveSettings.max"
[step]="moveSettings.step"
[pips]="sliderPips"
valueUnit="px/s"
[(ngModel)]="mouseMoveDeceleratedSpeed"
(ngModelChange)="onSetMouseMovePropertyValue('mouseMoveDeceleratedSpeed', $event)"/>
Expand All @@ -74,7 +70,6 @@ <h3>Mouse pointer speed</h3>
[min]="moveSettings.min"
[max]="moveSettings.max"
[step]="moveSettings.step"
[pips]="sliderPips"
valueUnit="px/s"
[(ngModel)]="mouseMoveAcceleratedSpeed"
(ngModelChange)="onSetMouseMovePropertyValue('mouseMoveAcceleratedSpeed', $event)"/>
Expand All @@ -85,7 +80,6 @@ <h3>Mouse pointer speed</h3>
[min]="0.1"
[max]="10"
[step]="0.1"
[pips]="sliderPips"
valueUnit=""
[(ngModel)]="mouseMoveAxisSkew"
(ngModelChange)="onSetPropertyValue('mouseMoveAxisSkew', $event)"/>
Expand Down Expand Up @@ -113,7 +107,6 @@ <h3>Mouse scroll speed</h3>
[min]="scrollSettings.min"
[max]="scrollSettings.max"
[step]="scrollSettings.step"
[pips]="sliderPips"
valueUnit="pulse/s"
[(ngModel)]="mouseScrollInitialSpeed"
(ngModelChange)="onSetPropertyValue('mouseScrollInitialSpeed', $event)"/>
Expand All @@ -124,7 +117,6 @@ <h3>Mouse scroll speed</h3>
[min]="scrollSettings.min"
[max]="scrollSettings.max"
[step]="scrollSettings.step"
[pips]="sliderPips"
valueUnit="pulse/s"
[(ngModel)]="mouseScrollBaseSpeed"
(ngModelChange)="onSetPropertyValue('mouseScrollBaseSpeed', $event)"/>
Expand All @@ -135,7 +127,6 @@ <h3>Mouse scroll speed</h3>
[min]="scrollSettings.min"
[max]="scrollSettings.max"
[step]="scrollSettings.step"
[pips]="sliderPips"
valueUnit="pulse/s"
[(ngModel)]="mouseScrollAcceleration"
(ngModelChange)="onSetPropertyValue('mouseScrollAcceleration', $event)"/>
Expand All @@ -146,7 +137,6 @@ <h3>Mouse scroll speed</h3>
[min]="scrollSettings.min"
[max]="scrollSettings.max"
[step]="scrollSettings.step"
[pips]="sliderPips"
valueUnit="pulse/s"
[(ngModel)]="mouseScrollDeceleratedSpeed"
(ngModelChange)="onSetPropertyValue('mouseScrollDeceleratedSpeed', $event)"/>
Expand All @@ -157,7 +147,6 @@ <h3>Mouse scroll speed</h3>
[min]="scrollSettings.min"
[max]="scrollSettings.max"
[step]="scrollSettings.step"
[pips]="sliderPips"
valueUnit="pulse/s"
[(ngModel)]="mouseScrollAcceleratedSpeed"
(ngModelChange)="onSetPropertyValue('mouseScrollAcceleratedSpeed', $event)"/>
Expand All @@ -168,7 +157,6 @@ <h3>Mouse scroll speed</h3>
[min]="0.1"
[max]="10"
[step]="0.1"
[pips]="sliderPips"
valueUnit=""
[(ngModel)]="mouseScrollAxisSkew"
(ngModelChange)="onSetPropertyValue('mouseScrollAxisSkew', $event)"/>
Expand Down
9 changes: 1 addition & 8 deletions packages/uhk-web/src/app/components/device/mouse-speed/mouse-speed.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, OnInit, OnDestroy } from '@angular/core';
import { Store } from '@ngrx/store';
import { AppState, getUserConfiguration } from '../../../store';
import { SetUserConfigurationValueAction } from '../../../store/actions/user-config';
import { SliderPips, SliderProps } from '../../slider-wrapper/slider-wrapper.component';
import { SliderProps } from '../../slider-wrapper/slider-wrapper.component';
import { Subscription } from 'rxjs';
import { faSlidersH } from '@fortawesome/free-solid-svg-icons';
import { ResetPcMouseSpeedSettingsAction, ResetMacMouseSpeedSettingsAction } from '../../../store/actions/device';
Expand Down Expand Up @@ -34,13 +34,6 @@ export class MouseSpeedComponent implements OnInit, OnDestroy {

diagonalSpeedCompensation: boolean;

public sliderPips: SliderPips = {
mode: 'positions',
values: [0, 50, 100],
density: 6,
stepped: true
};

public moveSettings: SliderProps = {
min: MOUSE_MOVE_VALUE_MULTIPLIER,
max: 6375,
Expand Down