Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color of text-muted css selector #2158

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix: color of text-muted css selector #2158

merged 2 commits into from
Jan 8, 2024

Conversation

ert78gb
Copy link
Member

@ert78gb ert78gb commented Jan 7, 2024

closes: #2149

Summary:

  • tried to follow the bootstrap 5 dark style. Because in the future we would like to switch to BS dark mode instead of custom dark mode.
  • use text-body-secondary as successor text-muted
  • --bs-secondary-color use the $secondary color in dark mode

Also fixing the keymap selector of the popover when the list item keymap equal to the currently selected keymap.

Before:
Screenshot 2024-01-07 at 14 59 37

After:
Screenshot 2024-01-07 at 15 02 10

Summary:
- tried to follow the bootstrap 5 dark style. Because in the future we would like to switch to BS dark mode instead of custom dark mode.
- use `text-body-secondary` as successor `text-muted`
- `--bs-secondary-color` use the `$secondary` color in dark mode
@ert78gb ert78gb requested a review from mondalaci January 7, 2024 14:03
@mondalaci mondalaci enabled auto-merge (squash) January 7, 2024 18:28
@mondalaci mondalaci merged commit 8d06b80 into master Jan 8, 2024
4 checks passed
@mondalaci mondalaci deleted the fix-muted-text branch January 8, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetics: text foreground in Firmware section
2 participants