(Alternate branch) Maybe fix spdlog for npm package. #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12438 This avoids doing very long pre-calculations for support generation when the mesh actually has no single overhang
CURA-12450 This is done be de-registering flooring areas once the briding mask has been calculated, and registering them as being classic skin areas.
CURA-12463 Shape::findInside is supposed to return NO_INDEX if there is no point inside, but when empty it was returning 0, which is definitely not a valid polygon index.
Should hopefully fix our problems with the NPM package building failing. CURA-12490
Found out it wouldn't compile in debug mode anymore otherwise -- at least on Windows. done as part of CURA-12490 -- but mostly unrelated to it
rburema
commented
Mar 19, 2025
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: c77d22e | Previous: 2c3d4e7 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_slot_noplugin |
1.8663804021838906 ns/iter |
1.243924324123529 ns/iter |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
… of spdlog to resolve. CURA-12470
It's inconvinient to do these on the buildserver, sorry for the commit spam! CURA-12470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...