Skip to content

Commit

Permalink
misc: Remove redundant pub keyword of helper functions
Browse files Browse the repository at this point in the history
Functions marked as `pub` in test module need to be documented. Since
these are literally helper functions and there is no need to be `pub`,
remove these `pub` keywords.

Signed-off-by: Ruoqing He <[email protected]>
  • Loading branch information
RuoqingHe authored and rbradford committed Oct 18, 2024
1 parent 416fe5e commit b708db3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions rate_limiter/src/group.rs
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,12 @@ pub(crate) mod tests {
use crate::{TokenBucket, TokenType, REFILL_TIMER_INTERVAL_MS};

impl RateLimiterGroupHandle {
pub fn bandwidth(&self) -> Option<TokenBucket> {
fn bandwidth(&self) -> Option<TokenBucket> {
let guard = self.inner.rate_limiter.inner.lock().unwrap();
guard.bandwidth.clone()
}

pub fn ops(&self) -> Option<TokenBucket> {
fn ops(&self) -> Option<TokenBucket> {
let guard = self.inner.rate_limiter.inner.lock().unwrap();
guard.ops.clone()
}
Expand Down
7 changes: 4 additions & 3 deletions rate_limiter/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,8 @@ pub(crate) mod tests {
}

// After a restore, we cannot be certain that the last_update field has the same value.
pub fn partial_eq(&self, other: &TokenBucket) -> bool {
#[allow(dead_code)]
fn partial_eq(&self, other: &TokenBucket) -> bool {
(other.capacity() == self.capacity())
&& (other.one_time_burst() == self.one_time_burst())
&& (other.refill_time_ms() == self.refill_time_ms())
Expand All @@ -553,12 +554,12 @@ pub(crate) mod tests {
}

impl RateLimiter {
pub fn bandwidth(&self) -> Option<TokenBucket> {
fn bandwidth(&self) -> Option<TokenBucket> {
let guard = self.inner.lock().unwrap();
guard.bandwidth.clone()
}

pub fn ops(&self) -> Option<TokenBucket> {
fn ops(&self) -> Option<TokenBucket> {
let guard = self.inner.lock().unwrap();
guard.ops.clone()
}
Expand Down

0 comments on commit b708db3

Please sign in to comment.