Implemented Cancel Button On Dialog (Blood Request Fragment).#96
Open
animeshroydev wants to merge 3 commits into
Open
Implemented Cancel Button On Dialog (Blood Request Fragment).#96animeshroydev wants to merge 3 commits into
animeshroydev wants to merge 3 commits into
Conversation
groverankush
requested changes
May 8, 2018
Collaborator
groverankush
left a comment
groverankush
left a comment
There was a problem hiding this comment.
Is the cancel button required? In the latest commit to develop the dialog has been made cancellable. I suggest that adding cancel button is just taking the screen space. The dialog is not of Alert type, presumably there's no need to add cancel button for this.
If it has to be added. I'll suggest a simple cross button on the top.
Your gitignore file is not properly configured. I request you to take pull of develop branch and get it rectified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included cancel button in blood request fragment
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Initially there was not back button in Blood Request Fragment Activity. I have added a rounded corner CANCEL button.
What is the current behavior? (You can also link to an open issue here)
When click on the CANCEL button it will get back to the HomeActiviity.
Other information:
I have added shapeone.xml in drawable folder for making the button rounded.
Screenshot (two screenshot (gif format): first runs In Android 5.1 and another in 4.4.2 Android OS Version)