Epc 611 rangefinder #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I don't know the use for UHD, for now the frame data is just dumped into an array. Polling is also now not useless and now holds the entire communication protocol together.
Tann90grin
commented
Mar 3, 2025
EPC611 Driver/epc611.cpp
Outdated
| HAL_GPIO_WritePin(gpio_nss,nss_pin,GPIO_PIN_RESET); | ||
| uint8_t send[2] = {data>>8, data&0x00FF}; // MSB first | ||
| uint8_t received[2] = {0}; | ||
| HAL_SPI_TransmitReceive(&hspi1, send, received, 2, SPI_TIMEOUT); | ||
| return received[0] | (received[1]<<8); | ||
| return received[0] <<8 | (received[1]); | ||
| HAL_GPIO_WritePin(gpio_nss,nss_pin,GPIO_PIN_SET); |
There was a problem hiding this comment.
This line would never be reached. Place it before return.
Tann90grin
commented
Mar 3, 2025
EPC611 Driver/epc611.cpp
Outdated
| HAL_GPIO_WritePin(gpio_nss,nss_pin,GPIO_PIN_SET); | ||
| } | ||
|
|
||
| uint16_t EPC611::write(uint8_t data,uint8_t address) { | ||
| uint16_t write = EPC_WRITE | data | ((address&0x1F) << 8); | ||
| return EPC611::epcSendRecv(write); | ||
| return EPC611::poll(write); |
There was a problem hiding this comment.
You can use this-> or simply just call the member function rather than class name
Tann90grin
commented
Mar 3, 2025
EPC611 Driver/epc611.cpp
Outdated
| } | ||
|
|
||
| // Returns 8 rows of sums for the 8x8 TOF sensor | ||
| void EPC611::getFrameUHD(uint16_t DCS_frames[][]) // Gets 4 frames because that's what the chip does for some reason |
There was a problem hiding this comment.
Could specify the array size or pointer
Tann90grin
commented
Mar 3, 2025
EPC611 Driver/epc611.cpp
Outdated
|
|
||
| bool EPC611::dataReady() | ||
| { | ||
| return (HAL_GPIO_WritePin(gpio_data_rdy,data_rdy_pin) == GPIO_PIN_SET); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.