Skip to content

Kl/scrum 147 fix timetable integration bugs#103

Merged
kevin-lann merged 7 commits intodevelopfrom
kl/scrum-147-fix-timetable-integration-bugs
Mar 25, 2025
Merged

Kl/scrum 147 fix timetable integration bugs#103
kevin-lann merged 7 commits intodevelopfrom
kl/scrum-147-fix-timetable-integration-bugs

Conversation

@kevin-lann
Copy link
Contributor

Description

SCRUM-147
SCRUM-152

  • Fixed semester change bug
  • Disabled manual flow checkbox after user generates timetable. This prevents user from trying to do manual flow while still in generate flow and provides better seperation of the two flows.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@thomasyzy7 thomasyzy7 changed the base branch from main to develop March 23, 2025 16:37
Copy link
Contributor

@Austin-X Austin-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested it out and it works for me.

Copy link
Contributor

@thomasyzy7 thomasyzy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@minhhaitran08 minhhaitran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has been fixed for table that I created for courses in Winter 2026.

However If I created a table for Fall 2025 and later update its courses to Winter 2026, the issue appear again.

image

@kevin-lann kevin-lann merged commit 198f5f2 into develop Mar 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants