Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/VETHUB-343 #26

Merged
merged 5 commits into from
Sep 23, 2024
Merged

feature/VETHUB-343 #26

merged 5 commits into from
Sep 23, 2024

Conversation

Mohamad11Dab
Copy link
Contributor 

git fetch
git checkout feature/VETHUB-343
yarn test

this ticket aims to:
1- Replace the hot spots with alphabets
2- shuffle the labels in box so that their order to match the alphabets

this is how it looks like on crucible:

Screenshot from 2024-09-20 15-57-04

Jo-Zh
Jo-Zh approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@Jo-Zh Jo-Zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consider another small ticket for refactoring the util getItemStyle in order to streamline the functions in the components.

everything else LGTM.

@Jo-Zh Jo-Zh merged commit 7378689 into main Sep 23, 2024
@Jo-Zh Jo-Zh deleted the feature/VETHUB-343 branch September 23, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jo-Zh Jo-Zh Jo-Zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mohamad11Dab @Jo-Zh