Chapter 9 Romanian Translation 🇷🇴 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chapter 9 was translated.
alexandruradovici
requested changes
Jan 20, 2023
Co-authored-by: Alexandru Radovici <[email protected]>
The one-liner solutions present in the code review suggestions have been added. Co-authored-by: Alexandru Radovici <[email protected]>
Author
|
I hope to make more time to properly fix or otherwise touch up the rest of the file after Monday, at most by next week's time. Until then I have to dedicate my time towards studies. |
The PI joke was replaced by the spanish version's joke.
Changed translation to better match other chapters.
alexandruradovici
approved these changes
Jan 24, 2023
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Send this pull request to upstream and place a link to it.
Author
|
Added a PR Upstream: |
alexandruradovici
added
the
upstream
|
What is your full name and group? |
This comment was marked as off-topic.
This comment was marked as off-topic.
alexandruradovici
changed the title
|
I suggest adding the Romanian flag 🇷🇴 (copy paste) to the upstream pull request title. |
richardanaya
pushed a commit
to richardanaya/tour_of_rust
that referenced
this pull request
Feb 4, 2023
* Chapter 9 Romanian Translation Chapter 9 was translated. * Update lessons/ro/chapter_9.yaml Co-authored-by: Alexandru Radovici <[email protected]> * Apply part of suggestions from code review The one-liner solutions present in the code review suggestions have been added. Co-authored-by: Alexandru Radovici <[email protected]> * Additional translation fixes This commit resolves the following suggestions: UPB-CS-OpenSourceUpstream#5 (comment) UPB-CS-OpenSourceUpstream#5 (comment) UPB-CS-OpenSourceUpstream#5 (comment) UPB-CS-OpenSourceUpstream#5 (comment) UPB-CS-OpenSourceUpstream#5 (comment) * Replaced PI joke The PI joke was replaced by the spanish version's joke. * Update translation Changed translation to better match other chapters. --------- Co-authored-by: Alexandru Radovici <[email protected]>
|
@MekalBoy Please select a timeslot for the interview https://doodle.com/meeting/participate/id/eZ8gOOEb. |
README has been updated to include Romanian chapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 9 was translated. With this being an initial draft, I am looking for feedback on whether or not the wording is appropriate.