Skip to content

Console empty string bug #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandruCarp wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Console empty string bug #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
302a97e
added check for command return and for buf size
alexandruCarp May 3, 2023
e0e3fc4
clippy error
alexandruCarp May 3, 2023
b308f77
added comment
alexandruCarp May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apis/console/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ impl<S: Syscalls, C: Config> Console<S, C> {
/// This is an alternative to `fmt::Write::write`
/// because this can actually return an error code.
pub fn write(s: &[u8]) -> Result<(), ErrorCode> {
// for an empty string the driver would never schedule an upcall, so the app would yield infinitely
if s.is_empty() {
return Ok(());
}
let called: Cell<Option<(u32,)>> = Cell::new(None);
share::scope::<
(
Expand Down