Deprecation warning fix #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added deprecation warning for when returning an instance of a strict subclass of complex.
removed label from unit test script for test_constructor
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
What issue are you solving?
Author
I solved a unit test that contained a known bug and that was marked as TODO. |
alexandruradovici
approved these changes
Jan 21, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Please send this to upstream and place a link to it here.
Author
alexandruradovici
requested changes
Jan 22, 2024
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
I suggest using the rust style function expression.
| )?; | ||
|
|
||
| return Ok(Some((ret.value, true))) | ||
| return Ok(Some((ret.value, true))); |
There was a problem hiding this comment.
Suggested change
| return Ok(Some((ret.value, true))); | |
| Ok(Some((ret.value, true))) |
Co-authored-by: Alexandru Radovici <[email protected]>
Co-authored-by: Alexandru Radovici <[email protected]>
…ython into complex-bug-fixes
Co-authored-by: Alexandru Radovici <[email protected]>
Co-authored-by: Alexandru Radovici <[email protected]>
Co-authored-by: Alexandru Radovici <[email protected]>
…ython into complex-bug-fixes
This reverts commit a19c9b7.
This reverts commit 8a021c2.
Co-authored-by: Jeong, YunWon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed case where returning strict subclasses of complex in complex doesn't give a deprecation warning.