Conversation
CMakeLists.txt
Outdated
| add_executable(UOSM_Telemetry_Pico ${SOURCES} ${UOSM_CORE_SOURCES}) | ||
| add_executable(UOSM_Telemetry_Pico ${SOURCES} ${UOSM_CORE_SOURCES} | ||
| Core/Tasks/CurrentVoltageTask.h | ||
| Core/Tasks/CurrentVoltageTask.cpp |
There was a problem hiding this comment.
We're working in C, not C++
If there's only C code in the file, it's as easy as renaming it to a .c
CMakeLists.txt
Outdated
| add_executable(UOSM_Telemetry_Pico ${SOURCES} ${UOSM_CORE_SOURCES} | ||
| Core/Tasks/CurrentVoltageTask.h | ||
| Core/Tasks/CurrentVoltageTask.cpp | ||
| Core/Tasks/Accelerometer.c |
There was a problem hiding this comment.
These .c files are done in the GLOB SOURCES at line 31
They should not be needed.
There was a problem hiding this comment.
I'll look into this. I believe CLion had automatically added these to the CMake file.
CMakeLists.txt
Outdated
| Core/Tasks/CurrentVoltageTask.h | ||
| Core/Tasks/CurrentVoltageTask.cpp | ||
| Core/Tasks/Accelerometer.c | ||
| Core/Tasks/accelerometer.h) |
There was a problem hiding this comment.
The .h files are included using the include directories command at line 20.
Shouldn't be needed
Core/Tasks/Accelerometer.c
Outdated
|
|
||
| #endif | ||
|
|
||
| void InitAccelerometer() { |
There was a problem hiding this comment.
This loop should be moved into a task file.
For example, look at the current sensor task.
The usual structure is 1 file to talk to the hardware, another file uses it.
That way, we make a seperation between the device itself and the usage
There was a problem hiding this comment.
In other words, the features that talk to the accelerometer should be in Core/UserDrivers/accelerometer.c
…h project naming convention
…ementation is deprecated.
The new AccelerometerTask.h file replaces this
Mostly just adding variables for the appropriate registers we want to access data from and/or use for config purposes
Using these functions, other accelerometer functions are starting to be implemented
# Conflicts: # Core/Tasks/TaskManager.c
Also cleaned up a comment
The same values/addresses were assigned to both before.
This had the same #define as accelerometer.h, which was causing problems linking files
This was causing problems with the current implementation
Still needs to be tested, but everything compiles
KrishS247
force-pushed
the
feature/accelerometer
branch
from
80797b4 to
63a47d6
Compare
2 participants
No description provided.