[Feat] 프로세스, 워크스페이스 엔티티 설계 및 DTO 정의 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggamnunq
reviewed
Jan 16, 2026
| import java.time.LocalDate; | ||
| import java.util.List; | ||
|
|
||
| public record ProcessCreateReqDTO( |
Collaborator
There was a problem hiding this comment.
기존 DTO들이 Dto처럼 소문자 형태를 띄고 있어서 이 부분 통일되면 좋을 듯 합니다
ggamnunq
reviewed
Jan 16, 2026
| @@ -0,0 +1,5 @@ | |||
| package com.nect.core.entity.team; | |||
|
|
|||
| public class ProjectUser { | |||
Collaborator
There was a problem hiding this comment.
엔티티인듯 한데, 최소한의 어노테이션이나 필드는 달아주세요
ggamnunq
reviewed
Jan 16, 2026
| private String fileName; | ||
|
|
||
| @Column(name = "file_ext", length = 10, nullable = false) | ||
| private String fileExt; // jpg, png, pdf, zip |
Collaborator
There was a problem hiding this comment.
확장자는 enum으로 두고 관리하는건 어떨까요
Collaborator
Author
There was a problem hiding this comment.
네 그게 좋을 것 같네요. 이것도 수정해 놓겠습니다
ggamnunq
reviewed
Jan 16, 2026
| // @JoinColumn(name = "created_by", nullable = false) | ||
| // private User createdBy; | ||
|
|
||
| @Lob |
Collaborator
There was a problem hiding this comment.
TEXT로 안 두고 Lob으로 둔 이유가 있을까요
Collaborator
Author
There was a problem hiding this comment.
columnDefinition="TEXT"으로 수정했어야 됐는데 수정을 못했습니다 수정해놓겠습니다
ggamnunq
reviewed
Jan 16, 2026
| this.status = ProcessFeedbackStatus.OPEN; | ||
| } | ||
|
|
||
| void setProcess(Process process) { |
Collaborator
Author
There was a problem hiding this comment.
넵 기본 접근제어자로 두고 addTaskItem 메소드 같은 편의 메서드 내에서만 호출되도록 제한했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat/team/team-init 팀 프로세스, 워크스페이스 관련 엔티티 설계 및 DTO 정의
🎯 작업 내용
주요 변경사항
상세 내용
✅ 체크리스트
💬 리뷰 요청사항