Enable Registration #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gambol99
commented
Jul 23, 2018
gambol99
commented
- adding the abilty for the admission controller to regsiter itself
cmd/policy-admission/main.go
Outdated
| @@ -95,6 +95,23 @@ func main() { | |||
| EnvVar: "CONTROLLER_NAME", | |||
| Value: "policy-admission.acp.homeoffice.gov.uk", | |||
| }, | |||
| cli.StringFlag{ | |||
| Name: "admission-service-name", | |||
| Usage: "kuberneres service name of the admission controller, used when registering `SERVICE`", | |||
There was a problem hiding this comment.
kuberneres => kubernetes
cmd/policy-admission/main.go
Outdated
| }, | ||
| cli.StringFlag{ | ||
| Name: "failure-policy", | ||
| Usage: "the failure policy when registering the controler `POLICY`", |
There was a problem hiding this comment.
controler => controller
cmd/policy-admission/main.go
Outdated
| }, | ||
| cli.StringFlag{ | ||
| Name: "certificate-bundle", | ||
| Usage: "file container the certificate authority bundle used when registering `PATH`", |
There was a problem hiding this comment.
file container the certificate authority bundle => file containing the certificate authority bundle
cmd/policy-admission/main.go
Outdated
| cli.BoolFlag{ | ||
| Name: "enable-registration", | ||
| Usage: "indicates you want the admission controller to self-register `BOOL`", | ||
| EnvVar: "ENABLE_EVENTS", |
There was a problem hiding this comment.
You need to change the EnvVar here
- adding the abilty for the admission controller to regsiter itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.