Feature branch GRO 165 #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mixin: 'radio-group', | ||
| validate: ['required'], | ||
| legend: { | ||
| className: 'visuallyhidden' |
There was a problem hiding this comment.
is this an existing css class name? if not, just call the class hidden, this is overly specific
There was a problem hiding this comment.
This is what is used for Hof components. The GDS class is govuk-visually-hidden .
william-gu-hof
approved these changes
Apr 5, 2024
…user in case email incorrect (TBC)
Adesh-Ramchurn
force-pushed
the
feature/GRO-165
branch
from
3510dec
to
ccba466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add new pages to form for verify email and use a different form for countries outside UK.
Why?
request by product Owners on tickets GRO-166-167 and GRO-165
How?
Updated the field.js to include new field "nonUkAddress" then updated the routes to include new url for new page "/address-nonuk" Then updated the applicant_emailer.js and caseworker_emailer.js and summary page to include the nonUkAddress field
and
create a new step: check-email in app.index.js update all the files related to check-email step to render the view check-email.html
Testing?
update test suit where possible. BDD will be update by QAT team
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit