Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new page - Enter your address in [country is not UK] #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Adesh-Ramchurn
Copy link
Contributor

What?

Added a new page for when country is non UK.

Why?

Product owner request GRO-167

How?

Updated the field.js to include new field "nonUkAddress" then updated the routes to include new url for new page "/address-nonuk" Then updated the applicant_emailer.js and caseworker_emailer.js and summary page to include the nonUkAddress field

Testing?

Conducted integration test. Did not conduct unit test as there were no logic change in the HoF-framework

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have integrated a JIRA number for my branch
  • I have integrated a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests (Handled in the feature branch)
  • I will squash the commits before merging

Copy link
Contributor

@shamiluwais shamiluwais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants