-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP GRO-148: Update Redis Image #300
Open
adityababumallisettiHO
wants to merge
18
commits into
master
Choose a base branch
from
GRO-148
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade Redis to 7.2 * Replace fedora with Rocky Linux * Trivy doesnt support Fedora
* fix drone pipeline issue * run yarn install to generate yarn.lock
* redis:v5.0.6-1 is updated to redis:v6.2.7-1 * Linux Distribution fedora:29 now updated to rockylinux:9.3 * Trivy isn't supporting Fedora
adityababumallisettiHO
changed the title
GRO-148: Update Redis Image
WIP GRO-148: Update Redis Image
Jan 24, 2024
adityababumallisettiHO
requested review from
sulthan-ahmed,
JHoldergov and
RobertMcCann
January 24, 2024 16:08
JHoldergov
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix Vulnerabilities in Redis Image.
Here are the Major Changes
Since Trivy Scanner isn't supporting Fedora OS. we decided to replace Linux Distribution fedora:29 with rockylinux:9.3. This have fixed some of the vulnerabilities in the OS base image
Current version of redis:v5.0.6-1 is upgraded to redis:v6.2.7-1
see tickets
https://collaboration.homeoffice.gov.uk/jira/browse/HOFF-308
https://collaboration.homeoffice.gov.uk/jira/browse/GRO-148
Why?
The CVE List is a set of records that describe specific vulnerabilities or exposures. It is maintained by a large community of trusted entities and individuals.
A vulnerability is a flaw in a software, firmware, hardware, or service component that can be exploited to cause a negative impact to the confidentiality, integrity, or availability of an impacted component or components.
An exposure is a code or configuration error that can be exploited to gain indirect and often hard-to-discover access to application data such as customer information.
How?
Used Trivy to Scan Redis Image.
To fix Yarn lock issue in Drone pipeline. Yarn lock has been deleted and Yarn install have regenerated Yarn.lock file
Built a new Redis image (v6.2.7-1) on rockylinux(v9.3) and no vulnerabilities found with Trivy Scanner
Please refer to below Trivy report,
https://confluence.bics-collaboration.homeoffice.gov.uk/pages/viewpage.action?spaceKey=FBISC&title=h[…]5846de1977705bc9e7db981381ec2d897cfde0b456a70
This is the Image: https://quay.io/repository/ukhomeofficedigital/redis-rockylinux?tab=tags
Testing?
Drone Job: https://drone-gh.acp.homeoffice.gov.uk/UKHomeOffice/gro/1096/1/9
Ingress URL : https://certificate-enquiries-gro-148.internal.gro-form-branch.homeoffice.gov.uk/about
Pods are healthy in Branch Env:
We will need to test the service in Branch Env before we deploy to rest of Environments
Pictures: