Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node from v14 to v18 #289

Closed
wants to merge 7 commits into from
Closed

Update Node from v14 to v18 #289

wants to merge 7 commits into from

Conversation

ChisomOguibe11
Copy link
Contributor

@ChisomOguibe11 ChisomOguibe11 commented Mar 10, 2023 •
edited
Loading

What?

Update project to Node version 18.15.0. see jira ticket #GRO-121.
https://collaboration.homeoffice.gov.uk/jira/browse/GRO-121

Why?

Part of Epic to upgrade all HOF services to Node v18. see jira ticket #HOFF-312
https://collaboration.homeoffice.gov.uk/jira/browse/HOFF-312

How?

  • Updated node engine inside package.json from 14.15.0 to 18.15.0
  • Updated main docker image to node:18-alpine
  • Changed all references to node:14 in drone.yml to node:18

Testing?

  • All unit tests + acceptance tests pass
  • Requires testing from QAT team

Screenshots (optional)

Anything Else?

@ChisomOguibe11 ChisomOguibe11 changed the title Update Node from v14.15.0 to v18.15.0 Update Node from v14to v18 Mar 13, 2023
@ChisomOguibe11 ChisomOguibe11 changed the title Update Node from v14to v18 Update Node from v14 to v18 Mar 13, 2023
@ChisomOguibe11
change nginx proxy base image tag from v1.2.3 to latest - resolves is…
1a42794 
…sue with nginx proxy auto-exiting on boot up
@ChisomOguibe11 ChisomOguibe11 marked this pull request as ready for review March 14, 2023 13:41
@ChisomOguibe11 ChisomOguibe11 requested review from MCrawleyHomeOffice and removed request for SarahJaneLuff March 14, 2023 13:42
sulthan-ahmed
sulthan-ahmed reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@sulthan-ahmed sulthan-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good man, before you merge it into master, I'm assuming you know for it to be tested by QAT then when they've OK'd it, can you squash the commits?

@ChisomOguibe11 ChisomOguibe11 removed the request for review from MCrawleyHomeOffice March 16, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulthan-ahmed sulthan-ahmed sulthan-ahmed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChisomOguibe11 @sulthan-ahmed @Rhodine-orleans-lindsay