Skip to content

Conversation

@SvilenDarvenyashki
Copy link
Contributor

@SvilenDarvenyashki SvilenDarvenyashki commented Oct 21, 2025

Provides an option to hide the icon of the UserSettingsItem used within UserSettingsDialog. If no icon property is added
the default icon that will be shown is 'globe'. Now if the icon property is set with empty string -> no icon will be shown.

Fixes: #12129

@cla-assistant
Copy link

cla-assistant bot commented Oct 21, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 21, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Oct 21, 2025

🧹 Preview deployment cleaned up: https://pr-12512--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 21, 2025 07:02 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 22, 2025 11:09 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 23, 2025 10:32 Inactive
@SvilenDarvenyashki SvilenDarvenyashki changed the title chore(ui5-user-settings-item): icon can now be hidden feat(ui5-user-settings-item): introduce option to hide icon Oct 27, 2025
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 27, 2025 11:09 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 27, 2025 11:27 Inactive
@SvilenDarvenyashki SvilenDarvenyashki merged commit 33b962f into main Oct 27, 2025
21 of 22 checks passed
@SvilenDarvenyashki SvilenDarvenyashki deleted the user-settings-item-no-icon branch October 27, 2025 12:10
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 27, 2025 12:11 Inactive
plamenivanov91 pushed a commit to plamenivanov91/ui5-webcomponents that referenced this pull request Oct 28, 2025
chore(ui5-user-settings-item): icon can now be hidden

Co-authored-by: Dobromira Boycheva <[email protected]>
Co-authored-by: ilhan orhan <[email protected]>
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.16.0-rc.3 🎉

The release is available on v2.16.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UserSettingsItem could not hide icon

5 participants