fix(ui5-carousel): exclude hidden items from rendering and navigation #12498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carousel now checks for empty content when data changes and hides empty slides. JIRA:BGSOFUIRODOPI-3548
|
🧹 Preview deployment cleaned up: https://pr-12498--ui5-webcomponents.netlify.app |
TeodorTaushanov
requested changes
Oct 27, 2025
Stoev
reviewed
Oct 27, 2025
GerganaKremenska
previously requested changes
Oct 27, 2025
duygu-rmdn
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Carousel component to properly handle hidden items by excluding them from rendering and navigation. The implementation adds a MutationObserver to track changes to item visibility, filters out hidden items from carousel operations, and ensures navigation indices are updated when items are dynamically hidden or shown.
Key Changes:
- Added MutationObserver to detect when content items are hidden/shown dynamically
- Introduced
_visibleItemsgetter to filter out items with thehiddenattribute - Updated all navigation and rendering logic to use visible items instead of all content items
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/main/src/Carousel.ts | Implements core logic for filtering hidden items, adds MutationObserver for dynamic updates, and refactors navigation to use visible items |
| packages/main/test/pages/Carousel.html | Adds interactive test cases for hidden items functionality with toggle and add operations |
| packages/main/cypress/specs/Carousel.cy.tsx | Adds automated test coverage for hidden items behavior in various scenarios |
TeodorTaushanov
approved these changes
Oct 27, 2025
plamenivanov91
pushed a commit
to plamenivanov91/ui5-webcomponents
that referenced
this pull request
Oct 28, 2025
…UI5#12498) JIRA:BGSOFUIRODOPI-3548
1 task
duygu-rmdn
added a commit
that referenced
this pull request
Oct 28, 2025
JIRA:BGSOFUIRODOPI-3548 Related with #12498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carousel now checks for empty content when data changes and hides empty slides.
JIRA:BGSOFUIRODOPI-3548