update make-data_krull2024.R - #33
Merged
Merged
Conversation
colData fixed, protein assay sample names did not match before
Member
|
Is this new data, or an existing one? |
Contributor
Author
|
This one already exists |
Member
|
Then we need to update the object in ExperimentHub. You probably also need to update the metadata, and bump the version of the object before doing so. Please check the corresponding vignette, send a new PR, and then get in touch with the core team (the email address is in the vignette) to get access to upload the new rds. I'm merging this PR already. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realised a mistake in colData while correcting the dataset with scplainer.
Sample names in the protein assay did not match those in colData; the issue has been fixed, and the corrected dataset will be re-uploaded.