-
Notifications
You must be signed in to change notification settings - Fork 99
ProjDataInMemory: avoid allocating with zero unless required #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3b2b84c
employed initialise_with_0 flag to reduce unnecessary 0-fill
evgueni-ovtchinnikov 377020b
corrected the default value of init_with_zeros_ in Array.h
evgueni-ovtchinnikov 7b416af
corrected ProjDataInMemory::create_buffer (size->max_index)
evgueni-ovtchinnikov ac31b6a
Merge branch 'master' into try-fix-algebra
evgueni-ovtchinnikov c3b25d6
followed pre-commit suggestions
evgueni-ovtchinnikov 3ff116d
adopted the reviewer's suggestions
evgueni-ovtchinnikov b05ba0c
adopted reviewer suggestion on bool arg for grow and resize
evgueni-ovtchinnikov 1e7ccbd
Merge branch 'master' into try-fix-algebra
evgueni-ovtchinnikov 241c041
implemented reviewer's suggestions
evgueni-ovtchinnikov 3fc482d
followed stackexchange advice on default arguments
evgueni-ovtchinnikov ece9b4b
adopted reviewer's suggestion on Array::grow and VectorWithOfset::grow
evgueni-ovtchinnikov 8cabab4
removed commented out backup lines
evgueni-ovtchinnikov 51fe530
Array::grow and Array::resize usage re-implemented properly
evgueni-ovtchinnikov 64b9f5a
got rid of unnecessary grow methods and commented-out lines
evgueni-ovtchinnikov 1bef628
final fix-up with doxygen
KrisThielemans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.