Skip to content

Commit

Permalink
Merge pull request #16 from Typefounding/updateLogic
Browse files Browse the repository at this point in the history
Update logic for public.openTypePostUnderlinePosition key
  • Loading branch information
benkiel authored Jul 12, 2023
2 parents 0209d97 + 1315261 commit 67c2839
Show file tree
Hide file tree
Showing 3 changed files with 176 additions and 152 deletions.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ This lists all currently-open UFOs. This now auto-updates when fonts are opened

### Underline Settings
- **Thickness:** The thickness of the underline. This corresponds to `font.info.postscriptUnderlineThickness`. Click "Sync" to set it to match the strikethrough thickness.
- **Position:** The position of the underline (the top of the line). This corresponds to `font.info.postscriptUnderlinePosition`.
- **Position:** The position of the underline (the top of the line).
- **Snap to Descender:** This will snap the descender value of selected fonts to bottom-align with `font.info.descender`. *Note: this will not write the values into the font yet. This is just a quick operation for your convenience.*
- **Snap to Below Descender:** This will snap the descender value of selected fonts to an underline-thickness-distance below `font.info.descender`. *Note: this will not write the values into the font yet. This is just a quick operation for your convenience.*

The underline position will be written into your UFOs using the `font.lib` key `public.openTypePostUnderlinePosition` (this is the value you set in **Position**) and to the `font.info.postscriptUnderlinePosition`. The extension calculates the value for `font.info.postscriptUnderlinePosition` (lowering the underline position by half of the underline thickness).

Read [here](https://learn.microsoft.com/en-us/typography/opentype/spec/post) for more guidance on setting these values.

### Strikethrough Settings
Expand Down
2 changes: 1 addition & 1 deletion Underline Strikethrough.roboFontExt/info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<key>timeStamp</key>
<real>1688077927</real>
<key>version</key>
<string>2.1</string>
<string>2.2</string>
<key>com.robofontmechanic.Mechanic</key>
<dict>
<key>repositoryURL</key>
Expand Down
Loading

0 comments on commit 67c2839

Please sign in to comment.