fix(review): Phoenix-MCP live polish — green row consistency + npx pre-install#85
Conversation
- ProofTimeline: make the whole Phoenix MCP row green (border + arrow + text), not just the text — the live state was visually inconsistent (amber border / arrow around green text). - Dockerfile.api: pre-install the pinned @arizeai/phoenix-mcp@4.0.13 globally so the per-request npx resolves from the image (no network fetch / version resolution on each audit) — cuts the live MCP round-trip latency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 28 minutes and 9 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ProofTimeline component to use the "good" color variable instead of the "warn" color variable when MCP is active. It also modifies the API Dockerfile to pre-install @arizeai/phoenix-mcp@4.0.13 to reduce latency. However, a review comment points out that installing the package globally will not prevent npx from performing a network fetch at runtime, and suggests installing it locally in the runtime directory instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # adk_runtime._PHOENIX_MCP_PACKAGE. | ||
| RUN ln -sf /usr/local/lib/node_modules/npm/bin/npm-cli.js /usr/local/bin/npm \ | ||
| && ln -sf /usr/local/lib/node_modules/npm/bin/npx-cli.js /usr/local/bin/npx \ | ||
| && npm install -g @arizeai/phoenix-mcp@4.0.13 \ |
There was a problem hiding this comment.
Installing @arizeai/phoenix-mcp globally (-g) will not prevent npx from attempting to fetch it from the registry at runtime. When npx is invoked with a specific version (e.g., npx -y @arizeai/phoenix-mcp@4.0.13), it does not resolve from global node_modules. Instead, it checks the local node_modules or its own cache, and if not found, it performs a network request to download it.
To ensure npx resolves the package locally without any network overhead or latency, install it locally in the /app directory (the runtime WORKDIR) using --no-save.
&& npm install --no-save @arizeai/phoenix-mcp@4.0.13 \
1 participant
Addresses the two medium CodeRabbit comments on #84:
--color-warn) around now-green text. Made the whole row green (--color-good) to match the live state.@arizeai/phoenix-mcp@4.0.13globally inDockerfile.apiso the per-requestnpxresolves from the image (no network fetch / version resolution on each audit), cutting the live MCP round-trip latency. Version kept in sync withadk_runtime._PHOENIX_MCP_PACKAGE.Web gates: typecheck · test (74) green. The Dockerfile pre-install is validated by CI's docker-build job.