feat(ui): expose 30d badges and response chart selector for duration #994
+42
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TwiN
requested changes
Feb 6, 2025
There was a problem hiding this comment.
I tried to build it locally and I got this:
VueCompilerError: Invalid end tag.
at <secret>/gatus/web/app/src/views/Details.vue:48:9
46 | <option value="7d">7 days</option>
47 | <option value="30d">30 days</option>
48 | </select>
| ^
49 | </div>
50 | <img :src="generateResponseTimeChartImageURL(selectedChartDuration)" alt="response time chart" class="mt-6" />
This reverts commit 517f0ce.
TwiN
reviewed
Feb 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
+ Coverage 75.82% 75.91% +0.08%
==========================================
Files 74 75 +1
Lines 6764 6883 +119
==========================================
+ Hits 5129 5225 +96
- Misses 1328 1345 +17
- Partials 307 313 +6 ☔ View full report in Codecov by Sentry. |
TwiN
requested changes
Feb 8, 2025
response time is only stored at 1h intervals, having a chart for the past 1h does not make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will expose the 30d badges in the endpoints details view, it may be confusing to not find it in the details view, as reported here.
Additionally, PR exposes a new dropdown menu in the endpoints details view to allow the user to select a different response time chart period. I'm a little unsure about the styling of it, but the end-result looks like this:
I noticed that there was no support for 1h response time chart. I added code for it with an additional test. If you want this present but with a dedicated PR please let me know.
Checklist
README.md, if applicable.