Skip to content

pin ForwardDiff=1 in test #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

pin ForwardDiff=1 in test #2581

wants to merge 3 commits into from

Conversation

penelopeysm
Copy link
Member

compathelper PR ran CI with ForwardDiff 0.10, so just want to check that it's really alright

don't merge this

Copy link
Contributor

github-actions bot commented Jun 4, 2025

Turing.jl documentation for PR #2581 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2581/

@penelopeysm penelopeysm changed the title fix ForwardDiff=1 in test pin ForwardDiff=1 in test Jun 4, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (8be9094) to head (b4c1e21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
+ Coverage   85.50%   85.57%   +0.06%     
==========================================
  Files          22       22              
  Lines        1456     1456              
==========================================
+ Hits         1245     1246       +1     
+ Misses        211      210       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm
Copy link
Member Author

penelopeysm commented Jun 13, 2025

1.10 test fails because FD=1 requires new Bijectors and new Bijectors requires 1.10.8. we don't need to push Turing to 1.10.8 on main, but we can at least test on CI with it in this pr to check if FD=1 introduces any issue on 1.10.8.

@coveralls
Copy link

coveralls commented Jun 13, 2025

Pull Request Test Coverage Report for Build 15641269588

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 85.636%

Totals Coverage Status
Change from base Build 15604552633: 0.07%
Covered Lines: 1246
Relevant Lines: 1455

💛 - Coveralls

@penelopeysm
Copy link
Member Author

random OptimizationOptimJL precompile failure reported upstream SciML/Optimization.jl#926

@penelopeysm
Copy link
Member Author

tests passed with FD@1 so we should be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants