Skip to content

Mark _evaluate!! as noinline #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/model.jl
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,13 @@ end

Evaluate the `model` with the arguments matching the given `context` and `varinfo` object.
"""
function _evaluate!!(model::Model, varinfo::AbstractVarInfo, context::AbstractContext)
@noinline function _evaluate!!(
model::Model, varinfo::AbstractVarInfo, context::AbstractContext
)
# NOTE(penelopeysm): This @noinline is a workaround for
# https://github.com/EnzymeAD/Enzyme.jl/issues/2337 and only really affects
# the smallest models (e.g. those with a single parameter). This call can
# be removed once that issue is fixed.
args, kwargs = make_evaluate_args_and_kwargs(model, varinfo, context)
return model.f(args...; kwargs...)
end
Expand Down