Skip to content

fix(ci): avoid restoring cached cargo binaries - #152

Merged
liuuys merged 4 commits into
TuGraph-family:masterfrom
liuuys:fix/ci-macos-rustup-init-issue
May 29, 2026
Merged

fix(ci): avoid restoring cached cargo binaries#152
liuuys merged 4 commits into
TuGraph-family:masterfrom
liuuys:fix/ci-macos-rustup-init-issue

Conversation

@liuuys

@liuuys liuuys commented May 15, 2026

Copy link
Copy Markdown
Contributor

fix(ci): avoid restoring cached cargo binaries

Type

  • feat: (new feature)
  • fix: (bug fix)
  • docs: (doc update)
  • refactor: (refactor code)
  • test: (test code)
  • chore: (other updates)

Scope

  • query: (query engine)
    • parser: (frontend parser)
    • planner: (frontend planner)
    • optimizer: (query optimizer)
    • executor: (execution engine)
    • op: (operators)
  • storage: (storage engine)
    • mvcc: (multi version concurrency control)
    • schema: (graph model and topology)
  • tool: (tools)
    • cli: (cli)
    • sdk: (sdk)
  • none: (N/A)

Description

Issue:

Run cargo nextest run --features std,serde,miette
  cargo nextest run --features std,serde,miette
  shell: /opt/homebrew/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    RUSTFLAGS: -Dwarnings
    RUST_BACKTRACE: 1
    CI: true
    DEFAULT_FEATURES: std,serde,miette
    CARGO_INCREMENTAL: 0
    CARGO_PROFILE_DEV_DEBUG: 0
    CARGO_TERM_COLOR: always
    CARGO_UNSTABLE_SPARSE_REGISTRY: true
    CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
    CACHE_ON_FAILURE: false
error: error: unexpected argument 'nextest' found

Usage: rustup-init[EXE] [OPTIONS]

For more information, try '--help'.


Stack backtrace:
   0: <std::backtrace::Backtrace>::capture
   1: anyhow::kind::Adhoc::new
   2: rustup::cli::setup_mode::main::{{closure}}::{{closure}}
   3: rustup_init::run_rustup_inner::{{closure}}::{{closure}}
   4: rustup_init::run_rustup::{{closure}}::{{closure}}
   5: rustup_init::main::{{closure}}
   6: tokio::runtime::runtime::Runtime::block_on
   7: rustup_init::main
   8: std::sys::backtrace::__rust_begin_short_backtrace
   9: _main
Error: Process completed with exit code 1.

Checklist

  • I have prepared the pull request title according to the requirements.
  • I have successfully run all unit tests and integration tests.
  • I have already rebased the latest master branch.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

…chain

Replace actions-rust-lang/setup-rust-toolchain@v1 with
dtolnay/rust-toolchain@master in the test job to fix macOS runners
where cargo resolves to rustup-init. Also reorder rust-cache before
taiki-e/install-action with cache-bin: false to prevent a polluted
~/.cargo/bin from being restored and overwriting cargo-nextest.
Copilot AI review requested due to automatic review settings May 15, 2026 08:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI workflow to address cargo nextest failures on macOS by adjusting Rust toolchain setup and caching behavior in the test job.

Changes:

  • Switch the test job’s Rust toolchain setup from actions-rust-lang/setup-rust-toolchain@v1 to dtolnay/rust-toolchain.
  • Disable ~/.cargo/bin caching in the test job (Swatinem/rust-cache with cache-bin: false) to avoid caching/restoring problematic binaries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@liuuys liuuys changed the title fix(ci): fix cargo nextest on macOS by switching to dtolnay/rust-tool… fix(ci): avoid restoring cached cargo binaries May 15, 2026
@liuuys
liuuys requested a review from Copilot May 15, 2026 12:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@qishipengqsp qishipengqsp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuuys
liuuys merged commit 53d567a into TuGraph-family:master May 29, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants