test: add TEST-02 update escrow real-limits report#89
Merged
armandocodecr merged 1 commit intoJun 17, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
51a15bd
into
Trustless-Work:multi-release-develop
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Issue Link
2. Brief Description of the Issue
[TEST-02] is an edge-case test of the Multi-Release V2
updateendpoint: verify the real limits of when properties can/can't change (funds held, active dispute, admin/platform immutability, balance = 0), the exact errors returned, and whether the equality check behaves as expected.This is a black-box test against the deployed Testnet API — no contract code changes. The deliverable is the results report.
3. Changes Made
report/TEST-02-report.mdwith the full results for scenarios A–F, plus an isolation sub-test (F2).GET /:contractIdstate, and the relevant on-chain transaction hashes.4. Evidence After Solution
Evidence is on-chain and verifiable: every action in the report includes its real Testnet transaction hash. Any hash can be checked at:
https://stellar.expert/explorer/testnet/tx/<hash>Example (Scenario A deploy): https://stellar.expert/explorer/testnet/tx/8aa90b37063f31be0e7f802972b753b110089245a87335b285ccf73977c066f0
5. Important Notes
approvers([A,B] → [B,A], same set) returnsESCROW_PROPERTIES_MISMATCH. Worth confirming whether ordering is intentional.manage-milestonesthen returnsESCROW_ALREADY_RELEASED. Sub-test F2 confirms multi-release itself is correct (releasing one milestone with another pending does not close the escrow), so this is an expected limitation, not a bug./fundonly accepts{contractId, signer, amount}and rebuilds the expected escrow from current on-chain state, so stale data can't be submitted.