Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update library to use SmartId V3.0.2 #1

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Update library to use SmartId V3.0.2 #1

wants to merge 64 commits into from

Conversation

Joeydelarago
Copy link

This is more or less a rewrite of the library for the SmartID v3 API.

Notable changes:

  • Version bumped to 1.0.0, there are many breaking changes.
  • QR Code Auth & Signing now available
  • Strong typing on all fields
  • Certificate validation is now done in the library
  • Digest validation is not done in the library
  • All public functions now return thiserror errors instead of anyhow. So the errors can be handled by projects including this lib.
  • State management included in the client (for calculating digests and getting session status)
  • Rust docs extended to most important functions and structs
  • Added some manual tests for running through the app flow with a device

@Joeydelarago
Use v3 endpoints
c937533
@Joeydelarago
Seperated V2 & V3. Add V3 models.
394af50
@Joeydelarago
Seperated V2 & V3. Add V3 models, V3 requests to validate
745a47e
@Joeydelarago
Fix Certificate request endpoint
52a9d39
@Joeydelarago
Do not accept invalid certs
66f286d
@Joeydelarago
validating the session response
e3b3206
@Joeydelarago
Add signature signing outline
6d8c908
@Joeydelarago
Update docs and examples
19c9d01
@Joeydelarago
More comments
1aa66b6
@Joeydelarago
Tests and comments
6cbddce
@Joeydelarago
clippy suggestions
ced0310
@Joeydelarago
clippy suggestions
33cf77f
@Joeydelarago
Fix cargo warnings
8dfc88b
@Joeydelarago
Replace unwrap with ?
3bb5260
@Joeydelarago
Add signature verification
4326735
@Joeydelarago
validate signatures
88bf81d
@Joeydelarago
Fix signature validation
3681658
@Joeydelarago
Manual tests
2ca6b6b
@Joeydelarago
Remove V2
2901f20
@Joeydelarago
Fix example
562b8a3
@Joeydelarago
rust format
e70e771
@Joeydelarago
Update tests
82e2cb1
@Joeydelarago
Fix signature encoding and url path
3a6c23e
@Joeydelarago
Fix dynamic link generation
ee4e53c
@Joeydelarago
Update tests
1ef2b1f
@Joeydelarago
Fix rsa signature check and update tests
baa53cb
@Joeydelarago
Add full signing test and fix issues
12ee10e
@Joeydelarago
Add signature validation
f7dae11
@Joeydelarago
Remove unused file
7f894b2
@Joeydelarago
Check the identity used to validate against the identity used to sign.
e9216c5 
Cleanup of response validation
@Joeydelarago
More documentation
e6957de
@Joeydelarago
Update tests
0c5fe73
@Joeydelarago
cargo fmt
dcf63a9
@Joeydelarago
organise dependencies
027a5b6
@Joeydelarago
More rust docs and examples
8943539
@Joeydelarago
Change environment variables names
91cb41f
@Joeydelarago
Remove async for new client
cf7b355
@Joeydelarago
Replace anyhow with SmartIdClient Errors in results so errors can be …
6ada7fa 
…caught.
@Joeydelarago
Wrap responses from api so that error responses can be parsed as well.
59522cf
@Joeydelarago
Add notifaciton based flows
3914368
@Joeydelarago
Change semantics identifier to build identifier on call.
ff81fd5
@Joeydelarago
Add display for semantic identifier.
155c868
@Joeydelarago
Allow config and session state to be serialized for session caching.
99ac1f1
@Joeydelarago
Add missing error
3aaab34
@Joeydelarago
Put session polling in configuration
1ecf5c7
@Joeydelarago
Make some session management functions public.
9dfcfe2
@Joeydelarago
Removed unused errors and rename errors to match others.
1fac9a4
@Joeydelarago
Update example
efec5b9
@Joeydelarago
Fix get request for long polling timing out because it is different f…
fbc771e 
…rom the long polling time.
@Joeydelarago
Improve error clarity
4f330e8
@Joeydelarago
Fix timeout response not returning correct error.
a8b07e1
@Joeydelarago
Add function to fetch signature algorithm.
090c473
@Joeydelarago
Clear sessions when starting a new session instead of after completin…
8d3fe09 
…g a session.

This allows us to access the session state after getting the status, for things like building an ACSP_V1 digest.
@Joeydelarago
Add function to build digest after getting response.
888d346 
This allows the digest to be fetched for ACSP_V1 signatures. This is only possible after recieving the server random from the response.
@Joeydelarago
Remove noisy genarting dynamic link logs
d3c2b5f
@Joeydelarago
cargo clippy
f54b461
@Joeydelarago
Fix raw digest signature checking.
1b5c5ae 
Verifying no hash rsa signatures is not supported by any of the major crates, so a custome implementation had to be created here.
@Joeydelarago
Use openssl::x509 to validate certificate chain.
555ce38 
This had to be switched because webpki fails when the TLS EKUs are not included in the cert, but we are validating signing certs not tls.
Add all demo/production certificates for skid to project.
Add option to pass additional certs to client.
@Joeydelarago
Add public function for verify certificate.
861e25e
@Joeydelarago
Return certificate chain from validation.
dae495d 
This is used in document signing for AdES-L/LTA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Joeydelarago