feat: add skeleton loading components and frontend unit tests#225
Merged
Conversation
- Add AssetCardSkeleton matching AssetCard layout (image, assetType, title, location, valuation, footer) - Add TextSkeleton and ImageSkeleton convenience wrappers in Skeleton/index.js - Update AssetGrid to use AssetCardSkeleton instead of raw Skeleton blocks - Skeleton coverage: AssetGrid, App metadata card, share balance, PortfolioPage rows
- Install vitest, @testing-library/react, @testing-library/jest-dom, jsdom - Configure vitest in vite.config.js with jsdom environment - Add test setup file with jest-dom matchers - Write 23 unit tests covering: - App initial render - Wallet connect (success + error) and disconnect - Buy shares validation (amount < 1) - Error display (Alert component, AssetGrid error state) - Metadata display (AssetCard, AssetGrid, useAssetStore) - Skeleton components (Skeleton, AssetCardSkeleton, TextSkeleton, ImageSkeleton) - Add 'test' and 'test:watch' scripts to package.json - Fix Skeleton/index.js -> index.jsx (JSX in .js caused rollup parse error)
|
@Shalom-margort Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #105
Closes #115
Changes
#105 — Skeleton loading components
AssetCardSkeletoncomponent matching AssetCard layout (image, type badge, title, location, valuation, footer)TextSkeletonandImageSkeletonconvenience wrappersAssetGridto useAssetCardSkeletonfor loading state#115 — Frontend unit tests (Vitest + React Testing Library)
testandtest:watchscripts to package.jsonTested
All 23 tests pass (
npm test→ 23 passed, 0 failed)