Wakamex fix/state cache chain collision#4002
Merged
Merged
Conversation
This commit fixes issue #3993 where the in-memory balance cache in GetBalanceAt() doesn't include the chain identifier in its cache key, causing potential collisions when the same process handles multiple chains. The issue: - GetBalanceAt uses an in-memory cache with key format: "address|blockNumber" - If the same Connection or process handles multiple chains (e.g., mainnet and gnosis), the cache could return incorrect balances from a different chain The fix: - Changed cache key format to include chain: "chain|address|blockNumber" - This ensures each chain has separate cache entries in the in-memory map Note: The filesystem cache already properly separates by chain through directory structure, so this fix only affects the in-memory cache. Example scenario that would trigger the bug: 1. Query balance on mainnet: chifra state --chain mainnet <addr> <block> 2. Query same address/block on gnosis: chifra state --chain gnosis <addr> <block> 3. Without this fix, the second query might return the cached mainnet balance\! 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This test verifies that the in-memory balance cache correctly includes the chain identifier in cache keys to prevent collisions when the same process handles multiple chains. The test demonstrates: - How the fixed cache key format prevents collisions - What would happen with the old format (one chain overwrites another) - The exact cache key format for different scenarios 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Fixes issue: #3993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Target Branch
developbranch for non-release changes.