Skip to content

Fix NameError: add default PidentComments#19

Open
yaro-lab wants to merge 3 commits into
Tropini-lab:mainfrom
yaro-lab:fix/pidentcomments-nameerror
Open

Fix NameError: add default PidentComments#19
yaro-lab wants to merge 3 commits into
Tropini-lab:mainfrom
yaro-lab:fix/pidentcomments-nameerror

Conversation

@yaro-lab
Copy link
Copy Markdown

Summary of changes

  • Added a safe default initialiser for PidentComments to prevent runtime NameError.
  • Ensured backward compatibility—if PidentComments is defined later, the behaviour remains unchanged.

✅ Testing

  • Code executes without errors across standard example runs.
  • Verified consistent primer-evaluation output with no side effects introduced.

🧩 Impact

  • Resolves script failure in the primer-QC stage.
  • Improves stability for users running PUPpy without additional configuration.

Fixes #13

@yaro-lab yaro-lab marked this pull request as ready for review October 31, 2025 14:23
@yaro-lab
Copy link
Copy Markdown
Author

Updates

  • Added my_tests/test_pidentcomments.py
  • Tests verify behaviour of pident_comment function and constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assistance Needed - NameError: name 'PidentComments' is not defined

1 participant