triton#323 Broken links in documentation#322
Conversation
bahamat
left a comment
There was a problem hiding this comment.
Hi, thanks for doing this!
There's just a couple of minor issues that need correcting. If you'll fix those, then I can merge this PR.
As for build-zone-setup.md, we currently use two different images for building:
- 2280cc86-6b5d-499f-9148-c4372dc316fc joyent-retro-20181206T011455Z
- 01d6f786-93f4-417b-a138-c76dd516b215 joyent-retro-20210826T002459Z
Writing all of that up might be a bit more work to get it all right. My suggestion would be to merge this PR once the corrections are made, then if you're feeling up to it, work on the build zone documentation as a separate PR. But, I'm not trying to shove work on you, so if you're not up for it, no worries. We'll take care of it sooner or later!
Everything else looks pretty good!
danmcd
left a comment
There was a problem hiding this comment.
coal-setup.md could use a little of this broken-link love as well.
Fixes as recommended in PR#322
Just went through the links in /docs/developer-guide/coal-setup.md, and I don't think I see any broken ones. Any specific ones? Maybe I'm missing something. |
While reading through the documentation, I noticed the link from /docs/developer-guide/iso-installer.md labeled "Booting the Head Node from a ZFS Pool" was broken. I cloned the repo, scrubbed all links starting with http, and fixed as many as I could.
developer-guide/build-zone-setup.md has a link to https://updates.tritondatacenter.com/images/bd83a9b3-65cd-4160-be2e-f7c4c56e0606?channel=experimental. I couldn't find a correct replacement.