Skip to content

triton#323 Broken links in documentation#322

Open
RDStewart wants to merge 2 commits into
TritonDataCenter:masterfrom
RDStewart:master
Open

triton#323 Broken links in documentation#322
RDStewart wants to merge 2 commits into
TritonDataCenter:masterfrom
RDStewart:master

Conversation

@RDStewart
Copy link
Copy Markdown

While reading through the documentation, I noticed the link from /docs/developer-guide/iso-installer.md labeled "Booting the Head Node from a ZFS Pool" was broken. I cloned the repo, scrubbed all links starting with http, and fixed as many as I could.

developer-guide/build-zone-setup.md has a link to https://updates.tritondatacenter.com/images/bd83a9b3-65cd-4160-be2e-f7c4c56e0606?channel=experimental. I couldn't find a correct replacement.

@bahamat bahamat changed the title Fixing broken links in documentation triton#323 Broken links in documentation Feb 13, 2023
Copy link
Copy Markdown
Contributor

@bahamat bahamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for doing this!

There's just a couple of minor issues that need correcting. If you'll fix those, then I can merge this PR.

As for build-zone-setup.md, we currently use two different images for building:

  • 2280cc86-6b5d-499f-9148-c4372dc316fc joyent-retro-20181206T011455Z
  • 01d6f786-93f4-417b-a138-c76dd516b215 joyent-retro-20210826T002459Z

Writing all of that up might be a bit more work to get it all right. My suggestion would be to merge this PR once the corrections are made, then if you're feeling up to it, work on the build zone documentation as a separate PR. But, I'm not trying to shove work on you, so if you're not up for it, no worries. We'll take care of it sooner or later!

Everything else looks pretty good!

Comment thread docs/developer-guide/repos.md Outdated
Comment thread docs/operator-guide/configuration.md Outdated
Copy link
Copy Markdown
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coal-setup.md could use a little of this broken-link love as well.

Fixes as recommended in PR#322
@RDStewart
Copy link
Copy Markdown
Author

coal-setup.md could use a little of this broken-link love as well.

Just went through the links in /docs/developer-guide/coal-setup.md, and I don't think I see any broken ones. Any specific ones? Maybe I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants