Core/AreaTriggers: Handle exit areatrigger on player map change #31077
Conversation
| @@ -1418,6 +1418,9 @@ bool Player::TeleportTo(TeleportLocation const& teleportLocation, TeleportToOpti | |||
| // remove all areatriggers entities | |||
| RemoveAllAreaTriggers(); | |||
|
|
|||
| // exit all areatriggers the unit is in | |||
| ExitAllAreaTriggers(); | |||
There was a problem hiding this comment.
including those that are attached to the player teleporting? what if there's no map change aura interrupt flag for an aura auratrigger
There was a problem hiding this comment.
thats pretty much the reason of this pr. Currently you can enter an areatrigger (e.g. Telash Frostbomb) and teleport to barrens and still keep the debuff. This PR prevents that
There was a problem hiding this comment.
my worry is that there might be aura areatriggers that aren't supposed to be removed from the unit (in this case a player) regardless of map change, unless there's proof that they're always removed and re-cast when they get into the new map if they happen to be the caster
|
|
||
| void Unit::ExitAllAreaTriggers() | ||
| { | ||
| for (AreaTrigger* at : m_insideAreaTriggers) |
There was a problem hiding this comment.
Will crash, HandleUnitExit calls ExitAreaTrigger which invalidates iterators (including .end())
Tests performed:
(Does it build, tested in-game, etc.)
tested ingame using Telash Greywing Frostbomb (spell 387149) in Azure Vault and then teleporting to barrens