Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multi-Factor Authentication #69

Closed
wants to merge 14 commits into from

Conversation

chesspro13
Copy link
Contributor

@chesspro13 chesspro13 commented May 7, 2024

Added A tab in the options menu to enable Multi-Factor Authentication (MFA) in the form of Time-Based One Time Passwords (TOTP) for a layer of security.

Addresses issue #68

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I'm surprised to see such a feature come so soon to Trilium Next, can't wait to test it.

In the mean time, could you please have a look at the whitespace changes (e.g. two spaces where there used to be four)? I would like them removed in order to maintain consistency.

@chesspro13
Copy link
Contributor Author

chesspro13 commented May 7, 2024

I'm canceling this pull request. I found a bug in the login causing MFA to be enabled before a secret is set. I'll update the white space as well.

Can you create a MFA branch that I can push to without pushing to the develop branch?

Edit: No bug, just didn't have the correct branch checked out.

@chesspro13 chesspro13 closed this May 7, 2024
@eliandoran
Copy link
Contributor

@chesspro13 , I've assigned you to the dev team, you should now be able to push your own branches.
Nevertheless, we still require PRs so that we can review them. When you create the PR from a branch from our fork, please make sure the target repository is TriliumNext, since GitHub can accidentally put the original one from zadam instead.

@eliandoran eliandoran added this to the Alpha release milestone Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants