build: merge copy-trilium.sh functionality into copy-dist.ts #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is useless at the moment, as all build processes are running "npm ci --omit=dev" anyways, i.e. they will just install everything remaining again
…rom copy-trilium in preparation to get rid of the file altogether - rest of the functionality will be merged into copy-dist.ts
helps avoiding downloading the packages a 2nd time during our prune stage
since we our own more "sophisticated" pruning during copy-dist, we need to set this to false, as otherwise build will fail
this is not needed anymore since commit 6b9d8f0
adapted from copy-trilium.sh
same as before, but some of the modules use singular/plural, so just check for both
deleting of ts and map files from node_modules folder, adapted from copy-trilium.sh.
* image-q/demo -> doesn't exist anymore (and even if it did - previous cleanup step, would've removed this anyways) * @excalidraw/excalidraw/dist/* -> updated to point to the dev folder * boxicons -> only fonts and css folders are used, so remove the other ones * jimp -> updated paths and removed non-existent path fixing here for historical reasons, next step is to move these over to copy-dist.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP that partially addresses #1174
-> moves functionality from
copy-trilium.shinto cross-platformcopy-dist.ts, so that we can get rid of one extra build script AND have other build processes also benefit from the copy-trilium.sh features (mainly "node_modules" cleanup -> which results in smaller file sizes for releases) -> this is currently only utilized for the "bare metal" Server build, but will now be available for all other builds as wellon a very first test, I got a reduction of 200+ MB of the node_modules folder this way