chore: fix lint issues in src/share

[pano9000]

WIP for fixing lint issues in src/share folder :-)

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/routes.spec.ts
  14:23  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/routes.ts
  186:29  error  Unexpected any. Specify a different type                                         @typescript-eslint/no-explicit-any
  197:38  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  213:46  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  223:55  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  236:64  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  258:66  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  284:83  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  302:76  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  324:60  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  342:47  error  'next' is defined but never used. Allowed unused args must match /^_/u           @typescript-eslint/no-unused-vars
  354:15  error  'note' is assigned a value but never used. Allowed unused vars must match /^_/u  @typescript-eslint/no-unused-vars

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/shaca/entities/sattachment.ts
  50:13  error  'content' is never reassigned. Use 'const' instead  prefer-const

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/shaca/entities/snote.ts
  108:13  error  'content' is never reassigned. Use 'const' instead  prefer-const
  215:23  error  Unexpected any. Specify a different type            @typescript-eslint/no-explicit-any
  229:18  error  'e' is defined but never used                       @typescript-eslint/no-unused-vars

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/shaca/shaca-interface.ts
  88:25  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/shaca/shaca_loader.ts
  96:8   error  'entityName' is defined but never used. Allowed unused args must match /^_/u  @typescript-eslint/no-unused-vars
  96:20  error  'entity' is defined but never used. Allowed unused args must match /^_/u      @typescript-eslint/no-unused-vars

✖ 19 problems (19 errors, 0 warnings)

Two errors will be left-over for now:

Two errors left:

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/shaca/entities/snote.ts
  229:18  error  'e' is defined but never used  @typescript-eslint/no-unused-vars

this one is a bit weird -> even if I prepend it with an underscore (to mark it as deliberately unused) it flags it as an issue.
I want to avoid needing to add a "eslint disable" comment for that line for now, so I'll just keep it "open" for a final review after I went through all the other folders, running eslint, first

/home/pano/Programming/0_repos/TriliumNextNotes/src/share/shaca/shaca-interface.ts
  88:25  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

currently struggling about the correct way to make TypeScript happy with this "dynamic" way of accessing the Shaca class' properties.

In Becca there is an additional if (!(camelCaseEntityName in this)), but it doesn't really help TS with narrowing down the type unfortunately.

will need to revisit later as well :-)

[eliandoran]

This is quite hard to read, I would prefer extracting it in a method and using if statements and writing a test for it.

[pano9000]

I assume you mean moving this as method into SNote class?

something like this?
It still looks ugly, but not much we can do about it I guess.
As I've noted in my commit message, using a schema validator like zod would make life a lot easier for these types of situation (but that would be something for the future, not this PR I'd say).

snote.ts

        getSvgContent() {
            const possibleSvgContent = this.getJsonContentSafely();

            return (typeof possibleSvgContent === "object"
                && possibleSvgContent !== null
                && "svg" in possibleSvgContent
                && typeof possibleSvgContent.svg === "string")
                    ? possibleSvgContent.svg
                    : null;
        }

routes.ts

        const contentSvg = image.getSvgContent();