Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: attach #869

Merged
merged 4 commits into from
Nov 10, 2024
Merged

docs: attach #869

merged 4 commits into from
Nov 10, 2024

Conversation

andretchen0
Copy link
Contributor

This PR adds tests, playgrounds, and docs for the attach prop.

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 96ba4e1
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/67309e974714290008109ca6
😎 Deploy Preview https://deploy-preview-869--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 changed the title docs/attach docs: attach Nov 3, 2024
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andretchen0 can't thank you enough for the quality of this PR 🙏🏻 it will be really useful for the community. I left a question on Discord but it's not blocking

@alvarosabu alvarosabu added docs Improvements or additions to documentation p1-chore Doesn't change end-user code behavior (priority) labels Nov 5, 2024
docs/advanced/attach.md Outdated Show resolved Hide resolved
@alvarosabu alvarosabu merged commit fbcbdc3 into main Nov 10, 2024
3 of 4 checks passed
@alvarosabu alvarosabu deleted the docs/attach branch November 10, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation p1-chore Doesn't change end-user code behavior (priority)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants