v3.3.0 #1020
Merged
v3.3.0 #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Erbil Nas <[email protected]>
This PR updates the cursor style of the Switch component to
`not-allowed` when it is disabled, improving user experience by
indicating that the component is not interactive in its disabled state.
### Changes
- Added the following CSS rule to the Switch component:
```css
:host([disabled]) .switch {
opacity: 0.5;
cursor: not-allowed; /* added this part */
}
### Issue Resolved
this PR resolves #942
Co-authored-by: Buse Selvi <[email protected]>
#940) ### Changes - Added visually hidden text to the navigation buttons for improved accessibility: - `<span class="visually-hidden">Previous Calendar View</span>` was added to the previous button. - `<span class="visually-hidden">Next Calendar View</span>` was added to the next button. ### CSS - Added the following CSS class to hide the text visually while keeping it accessible to screen readers: ```css .visually-hidden { position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0; overflow: hidden; clip: rect(0, 0, 0, 0); border: 0; } ### Related Issue Fixes #939 --------- Co-authored-by: Erbil <[email protected]>
improves type safety for * input * icon
#949) Add accessibility labels to close buttons of dialog and drawer component and also aria-label added to progress indicator ### Changes - Added a label to the close button in the dialog component for better accessibility. - Added a label to the close button in the drawer component for better accessibility. - Added aria-label to the progress indicator component for better accessibility. Co-authored-by: Erbil <[email protected]>
#946) ### Summary of Changes - Added keyboard functionality to the input component to toggle the checked state when the Enter or Space key is pressed. ### Changes Made 1. Implemented the handleKeyDown function: ``` private handleKeyDown(event: KeyboardEvent) { if (event.code === "Enter" || event.code === "Space") { this.checked = !this.checked; this.onChange(this.checked); event.preventDefault(); } } ``` 2. Associated the function with the @keydown event listener: `<input @keydown=${this.handleKeyDown} />` ### Reason for Changes This change was made to enhance user interaction with form elements via the keyboard and to improve accessibility. --------- Co-authored-by: Buse Selvi <[email protected]> Co-authored-by: Erbil <[email protected]>
Co-authored-by: Erbil <[email protected]>
Closes #905 --------- Co-authored-by: Ogun Babacan <[email protected]> Co-authored-by: Erbil Nas <[email protected]>
Signed-off-by: Erbil <[email protected]> Co-authored-by: Erbil Nas <[email protected]>
For closing #952 Co-authored-by: Erbil <[email protected]>
Signed-off-by: Aykut Saraç <[email protected]> Signed-off-by: Erbil <[email protected]> Co-authored-by: Aykut Saraç <[email protected]> Co-authored-by: Erbil <[email protected]> Co-authored-by: Enes Yıldırım <[email protected]>
Signed-off-by: Aykut Saraç <[email protected]> Signed-off-by: Erbil <[email protected]> Co-authored-by: dilan.dogan2 <[email protected]> Co-authored-by: Aykut Saraç <[email protected]> Co-authored-by: Enes Yıldırım <[email protected]>
#983) …e should also updated
Co-authored-by: Ogun Babacan <[email protected]> Co-authored-by: Erbil Nas <[email protected]>
customInvalidText, forceCustomError and clearCustomError are deprecated
refactor: improve form validation
#998) Issue When the user selects RTL mode, the calendar icons are swapped incorrectly. Fix Explicitly set direction: ltr to ensure icons remain in the correct order. Resolved incorrect icon placement while maintaining RTL layout. Issue: #997 --------- Co-authored-by: mehmet.tanas <[email protected]> Co-authored-by: Erbil <[email protected]>
This PR adds security-gates workflow and updates README with OpenSSF Scorecard badge.
This PR addresses and resolves issue #715. --------- Co-authored-by: Erbil <[email protected]>
This pr resolves #1010 Signed-off-by: AliYurtkulu <[email protected]> Co-authored-by: Erbil <[email protected]>
Signed-off-by: AliYurtkulu <[email protected]> Co-authored-by: AliYurtkulu <[email protected]> Co-authored-by: Erbil Nas <[email protected]>
Also use the appropriate custom event to ensure that the feature set works as intended. Closes #1017
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Co-authored-by: Erbil Nas <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -27,7 +27,7 @@ | |||
| - name: Run build | |||
| run: npm run build | |||
| - name: Create build artifact | |||
| uses: actions/upload-artifact@master | |||
| uses: actions/upload-artifact@main | |||
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
| retention-days: 5 | ||
|
|
||
| - name: "Upload to code-scanning" | ||
| uses: github/codeql-action/upload-sarif@v3 |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
| - name: Run linter check | ||
| run: npm run lint | ||
| - name: Run tests | ||
| run: npm run test | ||
| - name: Create coverage artifact | ||
| uses: actions/upload-artifact@v3 | ||
| uses: actions/upload-artifact@main |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
Co-authored-by: Erbil Nas <[email protected]>
Co-authored-by: Erbil Nas <[email protected]>
Co-authored-by: Erbil Nas <[email protected]>
## Figma Design Document https://www.figma.com/design/RrcLH0mWpIUy4vwuTlDeKN/Baklava-Design-Guide?node-id=25001-1763&t=xA7DTWjCkA2EqaDc-1 ## Implementation General usage example: ```html <bl-tag>In Progress</bl-tag> ``` ### Usage Examples Selectable variant usage: ```html <bl-tag @bl-tag-click="handleTagClick" selected>Selectable tag</bl-tag> ``` The removable variant can be set like this: ```js const handleTagClick=(event)=>{ tags.filter((tag)=>tag.value!==event.value) } <bl-tag variant="removable" @bl-tag-click="handleTagClick">Removable tag</bl-tag> ``` The icon can be set like this: ```html <bl-tag icon="info">Default</bl-tag> ``` The size and disabled attributes can be set like this: ```html <bl-tag size="large" disabled>In Progress</bl-tag> ``` ## API Reference: #### Slots | Name | Description | Default Content | |-------------|-----------------| --------------- | | `icon` slot | Icon of the tag | - | #### Attributes | Attribute | Description | Default Value | |----------------------|-----------------------------------------------|---------------| | size (`string`) | Size of tag(`small`,`medium`,`large`) | medium | | icon (`bl-icon`) | Name of the icon that will be shown in tag | - | | variant (`string`) | Variants of the tag(`selectable`,`removable`) | selectable | | disabled (`boolean`) | Makes tag disabled | false | | selected (`boolean`) | Makes tag selected | false | | value (`string`) | Sets tags value | - | ### Events | Name | Description | Payload | |----------------|----------------------------|-----------------------------------| | `bl-tag-click` | Fires when tag is clicked | `{value:string,selected:boolean}` | --------- Co-authored-by: AykutSarac <[email protected]> Co-authored-by: Buse Selvi <[email protected]> Co-authored-by: Erbil <[email protected]>
* fixes icon button by adding min-width * fix tag adr --------- Co-authored-by: Erbil Nas <[email protected]>
AykutSarac
approved these changes
Feb 20, 2025
fatihhayri
approved these changes
Feb 20, 2025
Co-authored-by: Erbil Nas <[email protected]>
Co-authored-by: Erbil Nas <[email protected]>
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.3.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.