Skip to content

Pluginval as dependency #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Pluginval as dependency #141

wants to merge 10 commits into from

Conversation

sudara
Copy link
Collaborator

@sudara sudara commented Dec 4, 2024

Opening as a draft for feedback and iteration.

Addresses #137

This improves support for pluginval as a CMake sub-project in a JUCE project.

  • Moves JUCE from submodule to CPM dependency on 8.0.4
  • Only adds JUCE when top level
  • Only sets deployment target when top level
  • Only generate docs when top level
  • Removes PLUGINVAL_FETCH_JUCE option (no longer needed, superseded by not being top level)

Open Questions:

  • Do we need to enforce minimum JUCE version for this use case?

Note to Dave and other maintainers:

With CPM, it's always a good idea to have the environment variable CPM_SOURCE_CACHE set — this will let you do offline builds vs. hitting the network on reconfigure. We can also add this optimization in CI too.

Add the following to .bashrc or .zshrc:

export CPM_SOURCE_CACHE=$HOME/.cache/CPM

The submodule is gone, so you can optionally clean up your .git/config folder, you can run:

rm -rf .git/modules/modules/juce 

@sudara sudara force-pushed the use-as-dependency branch from b708f38 to 4fea6f1 Compare December 4, 2024 17:14
@sudara sudara force-pushed the use-as-dependency branch from 89740ac to 1b833be Compare December 4, 2024 17:30
@sudara sudara changed the title Use as dependency Pluginval as dependency Dec 4, 2024
@sudara sudara marked this pull request as ready for review December 5, 2024 21:11
@sudara sudara marked this pull request as draft December 5, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant