Implement keystore encryption#4
Closed
leonardostsouza wants to merge 9 commits intoconvert-to-wallet-classfrom
Closed
Implement keystore encryption#4leonardostsouza wants to merge 9 commits intoconvert-to-wallet-classfrom
leonardostsouza wants to merge 9 commits intoconvert-to-wallet-classfrom
Conversation
b-garbacz
requested changes
May 8, 2025
b-garbacz
requested changes
May 8, 2025
leonardostsouza
force-pushed
the
implement-keystore-encryption
branch
from
f3ea460 to
dcdf1d2
Compare
petithomme
reviewed
May 12, 2025
petithomme
reviewed
May 12, 2025
petithomme
reviewed
May 12, 2025
petithomme
reviewed
May 12, 2025
b-garbacz
approved these changes
May 12, 2025
b-garbacz
reviewed
Jun 23, 2025
| }); | ||
| } | ||
| if (this.#readlineInstance != null) { | ||
| await this.#readlineInstance.close(); |
Contributor
There was a problem hiding this comment.
Did you test it manually with MSB? How interactive mod behaves?
leonardostsouza
force-pushed
the
implement-keystore-encryption
branch
from
d3a3740 to
1216780
Compare
Contributor
|
The keystore per se is somehow encrypted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.