Implement peer wallet factory methods#35
Draft
leonardostsouza wants to merge 71 commits intotrac-wallet-r2from
Draft
Implement peer wallet factory methods#35leonardostsouza wants to merge 71 commits intotrac-wallet-r2from
leonardostsouza wants to merge 71 commits intotrac-wallet-r2from
Conversation
…nvert-to-wallet-class
replaced Buffer with b4a added createHash method that utilizes sodium for sha256 and a custom generator if Pear is used for other types.
…e. this happened because there were 2 readline instances fighting over "dominance" if called from another app. initKeyPair now accepts an optional readline_instance argument where an existing instance can be passed and used instead.
…e. this happened because there were 2 readline instances fighting over "dominance" if called from another app. initKeyPair now accepts an optional readline_instance argument where an existing instance can be passed and used instead.
14 implement ci
* Add blake3 package * Add hash module * Fix broken module dynamics
* Refactor Wallet class to use trac-crypto-api * Implement brittle unit tests for address * Remove direct calls to sodium lib * Implement sign/verify tests * Implement tests for import/export keystore * Implement tests for hd wallet compatibility * Fix sign and verify static methods * Cleanup unused constants and dependencies * Fix type conversion on keypair sanitization
Fix CI - utilize brittle tests
* Implement key derivation support * Update wallet tests * Expose useful Trac Crypto Api functions * Remove unnecessary debug messages * Implement basic derivation path sanitization
Improved interaction for 12-24 word recovery
b-garbacz
force-pushed
the
trac-wallet-r2
branch
from
1551330 to
ed38c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor the whole trac-wallet code to make it cleaner and more maintainable. Also, we should export factory methods for the wallet, in order to make the developer interface more intuitive