Skip to content

Conversation

@SaffatHasan
Copy link
Contributor

Remove typo, fixes banking of crystal shards

https://oldschool.runescape.wiki/w/Crystal_shard

Remove typo, fixes banking of crystal shards
@Torwent
Copy link
Owner

Torwent commented Mar 8, 2025

So... This is actually not right.
But I could argue you are not wrong either.

I'll be taking a better look at this some day and it is going to take me some time, but "crystal shard" is the name and up text of a single shard, it is the uptext the game uses when you hover shards and the item name the wiki uses but it represents only a single shard while "crystal shards", according to the game cache is what represents all versions of the shards.

you can confirm yourself it yourself:

{$I SRL-T/osr.simba}

procedure TRSItemFinder.Show(item: TRSItem);
var
  display, img: TMufasaBitmap;
  i, h, w, x: Integer;
begin
  display.Init();

  for img in Self.GetItemImages(item) do
  begin
    if img.GetHeight() > h then h:= img.GetHeight();
    w := img.GetWidth();
    x := display.GetWidth();
    display.SetSize(x+w, h);
    display.DrawBitmap(img,[x,0]);
  end;

  display.Debug();
  display.Free();
end;

begin
  ItemfInder.Show('Crystal shards');
  Wait(5000);
  ItemfInder.Show('Crystal shard');
end.

Thanks for bringing this up tho, it can cause issues with stuff that relies on the item name like banking indeed, but that has to be fixed in banking not by changing the item name or you will only be able to find a single crystal shard and never multiple.

@Torwent Torwent closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants