Add Algorithms#8
Conversation
|
Hi @Teschl , there are some conflicts that should be resolved. I guess you are better at doing this than me. |
|
That was due to having already added the file in a pull request before, it's resolved now @wschwanghart . I'll try to combine extract_streams and stream_network into one function, with the option to decide which output is wanted. Also, I'm still working on shifting the resulting vector layer of stream_network into the right position. I'll mark this pull request as ready for review and mention you once that's done. |
|
I decided against putting both the stream_network vector and the raster version in the same Algorithm, since both outputs would always have to be defined. So in my opinion it's better to just separate them while giving them a similar name ( I also added the option in the There is one issue reaming with this function: running it twice after another will crash QGIS. I have not been able to pinpoint why this happens. It's not the shifting, I don't think it's the In my opinion it's fine for now, since this is a very early version, but this issue is something to keep in mind (I will create an issue to keep track of it). If you're ok with this should be ready to merge @wschwanghart |
This contains all existing at the time of closing #1 . extract_streams and stream_network do the same thing, so probably would have to be merged into one (or one of removed). There are also some issues with Shapefile results being offset by half a pixel. This why I'm opening this as a draft for now. To test this while the other pull requests (#5 , #6 , #7) are not merged jet, use the tmp branch.