feat: consume read/write metrics in execution timeline and resource p…#323
Open
amankoli09 wants to merge 1 commit into
Open
feat: consume read/write metrics in execution timeline and resource p…#323amankoli09 wants to merge 1 commit into
amankoli09 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #298
Description
This PR addresses the missing storage metrics in the
ExecutionTimelineandResourceProfiletrace UI components. While the type definitions forread_bytes,read_limit,write_bytes, andwrite_limitwere already available in the hooks, the frontend interface lacked the implementation to actually warn developers about limits for these storage variables.Changes Made
resourceProfileas a prop. It now displays a clear storage IO warning banner on the execution timeline whenread_bytesorwrite_bytesapproach the limits.trace.resource_profileto theExecutionTimelinecomponent in the tracepage.tsx.These changes give developers full visibility into both compute and storage bottlenecks, providing an early warning system before their contracts fail in production due to storage exhaustion issues (e.g., out of gas or
LimitExceededfailure).