fix: replace sync file read with async fs/promises and add error handling#322
Open
comzzy-comzzy wants to merge 1 commit into
Open
fix: replace sync file read with async fs/promises and add error handling#322comzzy-comzzy wants to merge 1 commit into
comzzy-comzzy wants to merge 1 commit into
Conversation
…ling Resolves Toolbox-Lab#307 - Replace dummy implementation with robust async TOML file reader - Use fs/promises for non-blocking file I/O with utf-8 encoding - Add targeted try/catch handling for ENOENT, EACCES, and EISDIR errors - Output actionable CLI diagnostic messages instead of raw stack traces - Parse TOML content using @iarna/toml and output as formatted JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #307 — Script crashes or hangs when reading the core TOML taxonomy file unsafely.
Changes
index.jswith a full async implementation usingfs/promisescrates/core/src/taxonomy/data/contract.tomlasynchronously (non-blocking)utf-8encoding to prevent raw Buffer returnstry/catchwith handling for specific Node.js error codes:crates/coresubmodule@iarna/tomland outputs the taxonomy as formatted JSONTesting
Closes #307