fix: resume WebSocket trace from cursor instead of replaying from start#321
Open
Babigdk wants to merge 1 commit into
Open
fix: resume WebSocket trace from cursor instead of replaying from start#321Babigdk wants to merge 1 commit into
Babigdk wants to merge 1 commit into
Conversation
The example WebSocket client had no reconnection logic and the server treated every (re)connection as a brand-new client, so a reconnect after a dropout replayed the entire trace - forcing the client to re-download and dedupe megabytes of already-received trace nodes. - Track a persistent `lastSeenNodeId` (the last node index seen) outside the connection scope and update it on every parsed `trace_node`. - Add a reconnection engine with capped exponential backoff. - Augment the reconnect `ws.send()` payload with `resume_from: lastSeenNodeId` so the server fast-forwards the replay to only unseen nodes. - Add defensive client-side dedup for any node already delivered. - Server now accepts `resume_from: Option<usize>` on TraceRequest and skips broadcasting nodes with index <= cursor. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #318