Skip to content

feat: single network selector across app, SDK, and indexer (#408) - #488

Merged
Psalmuel01 merged 2 commits into
ToluLabs:mainfrom
Richardkingz2019:fix/408-multi-network-config
Sep 2, 2026
Merged

feat: single network selector across app, SDK, and indexer (#408)#488
Psalmuel01 merged 2 commits into
ToluLabs:mainfrom
Richardkingz2019:fix/408-multi-network-config

Conversation

@Richardkingz2019

Copy link
Copy Markdown
Contributor

One selector (STELLAR_NETWORK / NEXT_PUBLIC_STELLAR_NETWORK, values testnet | mainnet | futurenet) now drives coherent config everywhere:

  • indexer: new src/networks.ts presets (Horizon, RPC, passphrase, explorer); config.ts resolves the preset and fails loudly at startup on mixed-network overrides (e.g. mainnet passphrase with testnet RPC)
  • frontend: lib/stellar.ts uses the same preset table; wallet kit, banners, and explorer links follow the selector
  • frontend: new lib/network-check.ts preflight surfaces mixed-network config in ConfigBanner before any signing happens; active network shown in the config banner
  • SDK: @stellarcred/sdk reads the same selector with per-network presets
  • .env.mainnet.example documents a mainnet deployment (re-deployed contract IDs, production Plaid, no cross-network overrides)

🤖 Generated with Codebuff

What does this PR do?

Closes #

Type of change

  • Bug fix
  • New feature / credential type
  • Refactor / cleanup
  • Docs
  • CI / tooling

Merge requirements

  • CI is greencargo test (contracts), pnpm tsc --noEmit (frontend), pnpm build (frontend), circuit tests — all green
  • Greptile confidence ≥ 4/5 — all review comments addressed, no unresolved threads
  • Circuit changes: fixtures/<type>/ artifacts updated
  • No NEXT_PUBLIC_ prefix on server-only env vars
  • No identity fields stored or logged after KYC provider call
  • prehash:false preserved on any issuer signing path touched
  • Issuer private key never referenced from client-bundled code

✅ Merge requirements

  • All CI checks pass (contracts / frontend / circuits as applicable)
  • Every Greptile review comment is addressed — no unresolved review threads
  • Greptile confidence score is 4/5 or higher

Notes for reviewers

closes #408

)

One selector (STELLAR_NETWORK / NEXT_PUBLIC_STELLAR_NETWORK, values
testnet | mainnet | futurenet) now drives coherent config everywhere:

- indexer: new src/networks.ts presets (Horizon, RPC, passphrase,
  explorer); config.ts resolves the preset and fails loudly at startup
  on mixed-network overrides (e.g. mainnet passphrase with testnet RPC)
- frontend: lib/stellar.ts uses the same preset table; wallet kit,
  banners, and explorer links follow the selector
- frontend: new lib/network-check.ts preflight surfaces mixed-network
  config in ConfigBanner before any signing happens; active network
  shown in the config banner
- SDK: @stellarcred/sdk reads the same selector with per-network presets
- .env.mainnet.example documents a mainnet deployment (re-deployed
  contract IDs, production Plaid, no cross-network overrides)

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@Richardkingz2019 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Psalmuel01
Psalmuel01 merged commit 1219a01 into ToluLabs:main Sep 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: multi-network config (testnet/mainnet) switch across app, SDK, and indexer

2 participants