feat(frontend): move issuer signing key to KMS/HSM abstraction - #460
Open
kuse-design wants to merge 1 commit into
Open
feat(frontend): move issuer signing key to KMS/HSM abstraction#460kuse-design wants to merge 1 commit into
kuse-design wants to merge 1 commit into
Conversation
Add an IssuerSigner interface in frontend/lib/signer.ts with two implementations: - EnvSigner: signs with a local secp256k1 private key (dev/mock only) - KmsSigner: delegates to AWS KMS via Sign(KeyId, Digest) — the raw private key never enters the Node.js process Selected via ISSUER_SIGNER=env|kms env var (defaults to env for local dev). KMS returns a DER signature which is converted to the raw (r,s) 64-byte form Noir expects. prehash: false semantics are preserved via KMS MessageType=DIGEST. The @stellarcred/issuer IssuerClient now accepts an IssuerSigner option alongside the legacy privateKey path, so existing code keeps working unchanged. Security notes documented in SECURITY.md. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@kuse-design Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an IssuerSigner interface in frontend/lib/signer.ts with two implementations:
Selected via ISSUER_SIGNER=env|kms env var (defaults to env for local dev). KMS returns a DER signature which is converted to the raw (r,s) 64-byte form Noir expects. prehash: false semantics are preserved via KMS MessageType=DIGEST.
The @stellarcred/issuer IssuerClient now accepts an IssuerSigner option alongside the legacy privateKey path, so existing code keeps working unchanged.
Security notes documented in SECURITY.md.
Generated with Codebuff 🤖
What does this PR do?
Type of change
Merge requirements
cargo test(contracts),pnpm tsc --noEmit(frontend),pnpm build(frontend), circuit tests — all greenfixtures/<type>/artifacts updatedNEXT_PUBLIC_prefix on server-only env varsprehash:falsepreserved on any issuer signing path touched✅ Merge requirements
closes #69